Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert "imp: remove LatestSequenceSend (#5108)" #5432

Merged
merged 12 commits into from
Dec 18, 2023
Merged

revert "imp: remove LatestSequenceSend (#5108)" #5432

merged 12 commits into from
Dec 18, 2023

Conversation

charleenfei
Copy link
Contributor

This reverts commit 34cbe05.

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@charleenfei charleenfei marked this pull request as ready for review December 18, 2023 13:47
@charleenfei charleenfei marked this pull request as draft December 18, 2023 13:47
@crodriguezvega crodriguezvega added channel-upgradability Channel upgradability feature priority PRs that need prompt reviews labels Dec 18, 2023
@charleenfei charleenfei marked this pull request as ready for review December 18, 2023 15:19
@charleenfei charleenfei marked this pull request as draft December 18, 2023 15:33
@charleenfei charleenfei marked this pull request as ready for review December 18, 2023 15:38
DimitrisJim
DimitrisJim approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left one minor code cov comment

colin-axner
colin-axner approved these changes Dec 18, 2023
View reviewed changes
proto/ibc/core/channel/v1/upgrade.proto Outdated Show resolved Hide resolved
@charleenfei charleenfei merged commit 9c346c5 into 04-channel-upgrades Dec 18, 2023
56 checks passed
@charleenfei charleenfei deleted the charly/revert_rm_lastseqsend branch December 18, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@damiannolan damiannolan Awaiting requested review from damiannolan

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
channel-upgradability Channel upgradability feature priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charleenfei @DimitrisJim @colin-axner @crodriguezvega